This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: ext/mt_alloc.h
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Stefan Olsson <stefan at snon dot net>
- Cc: libstdc++ at gcc dot gnu dot org, fnolis at home dot se
- Date: Tue, 20 May 2003 18:33:45 -0500
- Subject: Re: ext/mt_alloc.h
- References: <3EC9F8E1.7090500@snon.net>
>- There are quite a few different #ifndef naming conventions in use -
>which one should this file use (we chose __GLIBCPP_MT_ALLOC_H)?
I'm assuming _EXT_MT_ALLOC_H, although after a cursory review I can
understand your confusion.
>- Currently we include stl_alloc.h in this file since all the other
>"SGI-style" allocators have defined a set of alloc_traits thingies - is
>this needed?
I don't think so.
>If not it would suffice with stl_threads.h and functexcept.h?
Yep.
>- Which namespace should this code live in?
__gnu_cxx
>Also note that (as mentioned in the original posting
>http://gcc.gnu.org/ml/libstdc++/2003-03/msg00033.html) this allocator
>will currently only work on platforms using the pthread_* since there is
>no __gthread_mutex_init () call in gthr.h (we use pthread_mutex_init ()
>directly!).
I'll let Loren ponder this part.
With these changes, and confirmation from assign, I'd think this could go in.
best,
benjamin