This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] A generic basic_filebuf::_M_underflow
- From: Phil Edwards <phil at jaj dot com>
- To: P?tur Run?lfsson <peturr02 at ru dot is>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 7 May 2003 16:35:45 -0400
- Subject: Re: [PATCH] A generic basic_filebuf::_M_underflow
- References: <07D05A69A3D0C14FAEA60C3ACE8E5564028D0E01@nike.hir.is>
This isn't commit approval; I don't know enough about the wchar_t parts.
This is just commentary.
On Sun, May 04, 2003 at 10:47:50AM -0000, P?tur Run?lfsson wrote:
> * src/fstream.cc (basic_file::underflow, basic_file::uflow,
> basic_file::_M_underflow): Remove specializations.
> * src/Makefile.am (sources): Remove fstream.cc.
[...]
> Index: libstdc++-v3/src/fstream.cc
> ===================================================================
> RCS file: /home/petur/cvsroot/gcc/libstdc++-v3/src/fstream.cc,v
> retrieving revision 1.1.1.7
> diff -c -3 -p -r1.1.1.7 fstream.cc
> *** libstdc++-v3/src/fstream.cc 28 Apr 2003 21:16:34 -0000 1.1.1.7
> --- libstdc++-v3/src/fstream.cc 3 May 2003 17:18:22 -0000
> ***************
> *** 32,37 ****
> --- 32,38 ----
> // ISO C++ 14882: 27.8 File-based streams
> //
>
> + #if 0
> #include <fstream>
>
> namespace std
> *************** namespace std
> *** 222,224 ****
> --- 223,226 ----
> { return _M_underflow(true); }
> #endif
> } // namespace std
> + #endif // 0
Don't just #ifdef out the entire file. If we're not going to compile it
at all (changes to Makefile.am), just delete the file:
* src/fstream.cc (...what you wrote...): Remove specializations, delete file.
--
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace. We seek
not your counsel, nor your arms. Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen. - Samuel Adams