This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] More redundant NULL pointer checks


On Mon, Apr 21, 2003 at 12:21:32PM -0500, Benjamin Kosnik wrote:
> 
> Ok, except the sgetc change, don't do this. Also, your line breaks are funny:
> 
> +      const bool __testeof =
> +        traits_type::eq_int_type(__c, traits_type::eof());
> 
> Should be:
> 
> +      const bool __testeof = traits_type::eq_int_type(__c, 
> +                                                      traits_type::eof());

I disagree.  Indenting to the "(" eliminates most of the value
of the line break in the first place.  I thought I had written this 
choice into the formatting standard.  Emacs is easily fixed to do
the right thing.

Nathan Myers
ncm-nospam at cantrip dot org


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]