This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Fix collate_members_char[wchar_t].cc
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Paolo Carlini <pcarlini at unitus dot it>
- Cc: Ulrich Drepper <drepper at redhat dot com>, libstdc++ at gcc dot gnu dot org
- Date: Thu, 14 Mar 2002 09:29:01 -0800 (PST)
- Subject: Re: [PATCH] Fix collate_members_char[wchar_t].cc
> > > > > - VERIFY(i1 == i2);
> > > > > + VERIFY(i2 == 1);
> >
> > The original code is correct and according to what you just said it
> > would work for you as well. So dump the change and use the original
> > VERIFY.
>
> Sorry. I think there is a misunderstanding. I cannot use the original VERIFY
> because string::compare does /not/ normalize! (I don't have the standard here,
> but, f.i., Josuttis, p. 511).
So, shouldn't it be
+ VERIFY(i2 > 0);
?
-benjamin