This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: AIX, Solaris 2.8 excess errors fails
- From: Phil Edwards <phil at jaj dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: David Edelsohn <dje at watson dot ibm dot com>, Jason Merrill <jason at redhat dot com>, Benjamin Kosnik <bkoz at redhat dot com>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Sun, 10 Mar 2002 16:20:21 -0500
- Subject: Re: AIX, Solaris 2.8 excess errors fails
- References: <200202210340.WAA22856@makai.watson.ibm.com> <6070000.1014265293@warlock.codesourcery.com>
On Wed, Feb 20, 2002 at 08:21:33PM -0800, Mark Mitchell wrote:
> > Well, I was thinking of letting the test fail on systems without
> > weak symbol support. But if you want to have the test adapt to the system
> > on which it is being tested (as you suggest) instead of unilaterally
> > instantiating the static members on all systems, I agree that is an
> > improvement.
>
> Good. Now that we have decided, we just have to get the V3 people to
> adopt this as official testsuite policy. I can't imagine they'd want
> to think about this now that we've rendered our decision from on
> high, but you never know. :-) :-)
Hey, the less thinking we need to do, the better! (Er, wait, that didn't
come out quite right.)
Benjamin, sanity check? Works on linux for me:
Index: testsuite/21_strings/capacity.cc
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/libstdc++-v3/testsuite/21_strings/capacity.cc,v
retrieving revision 1.6
diff -u -3 -r1.6 capacity.cc
--- testsuite/21_strings/capacity.cc 20 Feb 2002 00:58:15 -0000 1.6
+++ testsuite/21_strings/capacity.cc 10 Mar 2002 18:45:06 -0000
@@ -188,6 +188,7 @@
return test;
}
+#if !__GXX_WEAK__
// Explicitly instantiate for systems with no COMDAT or weak support.
template
std::basic_string< A<B> >::size_type
@@ -196,6 +197,7 @@
template
A<B>
std::basic_string< A<B> >::_Rep::_S_terminal;
+#endif
int main()
{
Index: testsuite/27_io/ios_init.cc
===================================================================
RCS file: /home/pme/Repositories/GCC/gcc/libstdc++-v3/testsuite/27_io/ios_init.cc,v
retrieving revision 1.6
diff -u -3 -r1.6 ios_init.cc
--- testsuite/27_io/ios_init.cc 27 Feb 2002 01:01:31 -0000 1.6
+++ testsuite/27_io/ios_init.cc 10 Mar 2002 18:46:57 -0000
@@ -132,6 +132,7 @@
VERIFY( test );
}
+#if !__GXX_WEAK__
// Explicitly instantiate for systems with no COMDAT or weak support.
template
std::basic_string<unsigned short>::size_type
@@ -140,6 +141,7 @@
template
unsigned short
std::basic_string<unsigned short>::_Rep::_S_terminal;
+#endif
int main()
{