This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Group octs and hexs too (was: Re: [RFC] 27_io/ios_manip_basefield.cc)
- From: Paolo Carlini <pcarlini at unitus dot it>
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Tue, 26 Feb 2002 22:47:42 +0100
- Subject: Re: [PATCH] Group octs and hexs too (was: Re: [RFC] 27_io/ios_manip_basefield.cc)
- References: <Pine.SOL.3.91.1020226124134.4116A-100000@taarna.cygnus.com>
Benjamin Kosnik wrote:
> > I think I have strictly implemented our current best interpretation. I have also
> > added a few more tests. If the patch is ok, please let me know if it is ok for
> > the branch too.
>
> This looks fine for gcc-head and gcc-3_1-branch. Thanks!
Done!
> > Another thing: of course there are no regressions in the testsuite, but I think
> > we have still to *carefully* check that this kind of output can be parsed
> > successfully by the corresponding get code. Benjamin could you possibly help me
> > on this? Which are the most delicate points?
>
> I think this is already handled correctly, but I'm not quite sure if
> it's explicitly tested for: they'd be in
>
> 22_locale/num_get_members_*.cc
>
> In particular, the const void bit.
>
> Probably a test04() should be added that checks for both kinds of
> grouping in oct/hex input.
Thanks. Tomorrow, I will look into it.
Ciao, Paolo.