Re: [PATCH] Money_get::do_get: first create, then destroy

[Paolo Carlini <pcarlini at unitus dot it>]

Benjamin Kosnik wrote:

>This is fine thanks. Actually, it's a nice patch, testsuite entry, etc. I 
>love that kind of patch.
>
Thanks.

>Do you know if this kind of thing happens in other, 
>related facets (num_get, time_get) or the sister money facet (money_put?)
>I usually try to do a full audit for regressions like this. If
>you can, you might want to glance around the other facets to see if this
>same class of regression could exist elsewhere.
>
Sure. My feeling is that the money_get::do_get(string) case is quite 
exceptional, but indeed I will check the other facets in the next days...

>>P.S. I'm afraid we are still not doing always the right thing when the sign is
>>longer than 1 char. I will tackle this next.
>>
>Great.
>
... after having sorted out this (I think it's quite simple in fact, 
just an additional || in the condition at the beginning of case symbol)

>The en_HK locale tests exercise a lot of (pathalogical/odd) behavior WRT
>sign issues, so make sure that you are testing with more than the "C" 
>locale... you've probably already noticed the testsuite entries, but I 
>thought I'd give you a heads up anyway.
>
I see. Thanks.

Ciao, Paolo.