This is the mail archive of the
libstdc++@sources.redhat.com
mailing list for the libstdc++ project.
Re: [PATCH] Revised BeOS libstdc++ patch
- To: Daniel Berlin <dberlin at cygnus dot com>
- Subject: Re: [PATCH] Revised BeOS libstdc++ patch
- From: Jason Merrill <jason at redhat dot com>
- Date: Fri, 24 Nov 2000 15:47:55 GMT
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at sources dot redhat dot com
- References: <Pine.SOL.3.91.1001122100017.19538A-300000@cse.cygnus.com>
>>>>> "Daniel" == Daniel Berlin <dberlin@cygnus.com> writes:
> Here's the real patch I meant to submit, including rth's suggested use of
> making _Atomic_swap i386 specific, rather than BeOS specific.
> Really, it should be in atomicity.h, but that's not my call.
I strongly agree. I find the STL headers to be far too #ifdef-heavy
for my taste; I much prefer the GCC approach to portability.
But you also seem to be introducing platform #ifdef-ery into files
that aren't already (so) polluted: _G_config.h and gen-num-limits.cc.
Is there a reason those changes can't use stuff defined in one of the
config files?
Jason