This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
RE: [PATCH] Fix FFI return type for proxy classes
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: "'gcc-patches at gcc dot gnu dot org' (gcc-patches at gcc dot gnu dot org)" <gcc-patches at gcc dot gnu dot org>, "java-patches at gcc dot gnu dot org" <java-patches at gcc dot gnu dot org>, "aurelien at aurel32 dot net" <aurelien at aurel32 dot net>
- Date: Wed, 13 Jul 2016 21:37:23 +0000
- Subject: RE: [PATCH] Fix FFI return type for proxy classes
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B023537E474A5F@HHMAIL01.hh.imgtec.org> <874m7upz18.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
> >>>>> "Matthew" == Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
>
> Matthew> Tested on: x86_64-pc-linux-gnu (default and -m32), mips-linux-gnu
> Matthew> mipsel-linux-gnuabi64 with no regressions. The new test only failed
> Matthew> on mips-linux-gnu prior to patching libjava.
>
> Matthew> libjava/
> Matthew> * java/lang/reflect/natVMProxy.cc (unbox): Use ffi_arg for
> Matthew> integer return types smaller than a word.
> Matthew> * testsuite/libjava.jar/ReturnInvocationHandler.java: New file.
> Matthew> * testsuite/libjava.jar/ReturnProxyTest.jar: Likewise.
> Matthew> * testsuite/libjava.jar/ReturnProxyTest.java: Likewise.
> Matthew> * testsuite/libjava.jar/ReturnProxyTest.out: Likewise.
> Matthew> * testsuite/libjava.jar/ReturnProxyTest.xfail: Likewise.
> Matthew> * testsuite/libjava.jar/ReturnTypes.java: Likewise.
> Matthew> * testsuite/libjava.jar/ReturnTypesImpl.java: Likewise.
>
> Thanks for writing this.
> This is ok.
Thanks for the review.
Committed as r238312. This also needs a backport to GCC 5 and 6 but I will
give it a week or so before proposing.
Thanks,
Matthew