Re: PATCH: Fix 64-bit libffi testsuite on Solaris 10+ (PR libffi/40700)

[Andreas Tobler <andreast-list at fgznet dot ch>]

On 20.12.09 03:21, Gerald Pfeifer wrote:
> On Thu, 10 Dec 2009, Andreas Tobler wrote:
> > Anyway, there are other architectures which do have the same issue. FreeBSD,
> > OpenBSD, apple-darwin10. We 'solved' this with adding the snippet below in the
> > configure.ac (from the libffi sources, not in the gcc repo yet.):
> >
> > case "$target" in
> >      *-apple-darwin10* | *-*-freebsd* | *-*-openbsd*)
> >          AC_DEFINE(FFI_MMAP_EXEC_WRIT, 1,
> >                    [Cannot use malloc on this target, so, we revert to
> >                     alternative means])
> >      ;;
> >
> >
> > So, my question, shall we move the three remaining OS variants into the
> > closures.c file. Or should we move the solaris/x86 part from the closures.c
> > file into the configure.ac part?
>
> Are you planning on addressing this for the three platforms (Darwin,
> FreeBSD, OpenBSD) for GCC 4.5?  Or do we have a different fix in the
> GCC tree for the time being?

Yes, it's planned. I should come up soon with a proposal.

Andreas