This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, take 2] Build java as two separate DLLs on windows.


Ralf Wildenhues wrote:
> Hello Dave,
> 
> * Dave Korn wrote on Mon, Aug 31, 2009 at 09:02:37PM CEST:
>> libjava/libltdl/ChangeLog:
> 
>> 	* Makefile.am (libltdl_la_LDFLAGS): Remove -bindir switch.
>> 	* Makefile.in: Regenerate.
> 
> Why is this bit part of this big patch?  It could be a separate patch,
> as it is a fixup of your earlier -bindir patch.  And IIUC it's obvious,
> too (you are undoing part of an earlier patch of yours).

  Was being slightly lazy.  If this patch gets approved fairly soon I'll roll
it up in, but if it's more than a few days I guess I could commit that bit
first.  I mean, technically I could break the whole thing down into a number
of subpatches, one that builds a single broken DLL, then another that splits
it into two DLLs that don't work very well, then another to turn on JCR
sections and make them PASS a few more tests, then another to fix the
backtrace bug and PASS a few more tests - but I didn't want to do it that way
(and the extra cpu cycles of running all those tests separately one on top of
the other on top of the other would likely run over the end of stage 1), so I
figured on presenting "Here in one fell swoop is everything we need to make
libjava good on windows".

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]