This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Some patches to break dependencies in libgcj
- From: Andrew John Hughes <gnu_andrew at member dot fsf dot org>
- To: David Daney <david dot s dot daney at gmail dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Sun, 30 Aug 2009 17:08:30 +0100
- Subject: Re: Some patches to break dependencies in libgcj
- References: <4A9A1DBD.4010208@gmail.com>
2009/8/30 David Daney <david.s.daney@gmail.com>:
> Attached are some patches I developed to break some dependencies in libgcj.
> ÂThe use case I was addressing was to minimize executable size with
> -static-libgcj, but the patches may be interesting in other contexts. ÂI
> don't plan on committing these myself, but if others are interested in
> testing and committing them or using them as the basis for other work, feel
> free to do so.
>
> David Daney
>
>
>
I think the first three should be applied to Classpath (if at all)
rather than creating further divergence in gcj.
The first patch seems ok, though it does make the class more
susceptible to changes in package naming (at present, it would break
at compile time, with the patch it would require a runtime check).
The changes in the second patch seem to be lost in whitespace adjustments.
With the third patch, I wonder if we couldn't just supply the default
implementation via META-INF and remove that instantiation altogether.
I'll leave comments on the fourth patch to those who know the gcj
makefiles better than I do :)
--
Andrew :-)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8