This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Fix Cygwin bootstrap, PR40807 and all significant FAILs on win32.
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Andrew Haley <aph at redhat dot com>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, libffi-discuss at sourceware dot org, Java Patches <java-patches at gcc dot gnu dot org>, Rainer Emrich <rainer at emrich-ebersheim dot de>
- Date: Thu, 23 Jul 2009 11:32:43 +0100
- Subject: Re: [PATCH] Fix Cygwin bootstrap, PR40807 and all significant FAILs on win32.
- References: <4A676BBB.3060104@gmail.com> <4A683873.2020800@redhat.com>
Andrew Haley wrote:
> On 07/22/2009 09:42 PM, Dave Korn wrote:
>> Hi all,
>>
>> While I was looking at the dlmmap/dlmunmap code in closures.c, I started
>> looking into testsuite FAILs to see if any of them might be caused by the code
>> I had added, and stumbled across a bigger can of worms. The code in win32.S
>> doesn't take account of numerous among the FFI_TYPE_xxx return types, leading
>> to stack-based garbage being returned, and in one place mishandles the ABI
>> convention that the callee should pop the hidden pointer arg for struct return
>> types.
>>
>> Before this patch there were 66 FAILs on libffi HEAD (sourcware) and 20 on
>> libffi GCC. After, there are only one or two remaining (depending on GCC
>> version), both "test for excess errors" failures related to format-string
>> warnings and unrelated to all this. Tested on i686-pc-cygwin; the GCC testing
>> only involved bubblestrapping an existing $objdir rather than running a full
>> bootstrap, but that should be OK for a target lib.
>
> Did you run the gcj testsuite? If so, what were the results?
I started it but got hit by a power outage overnight. I just restarted
another testrun but it'll take a while to complete (8-10 hours or so?).
cheers,
DaveK