This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] libffi testsuite: Correct some type specifiers.

From: David Daney <ddaney at avtrex dot com>
To: tromey at redhat dot com
Cc: GCJ-patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, andreast at gcc dot gnu dot org
Date: Tue, 07 Aug 2007 10:17:49 -0700
Subject: Re: [Patch] libffi testsuite: Correct some type specifiers.
References: <46B89D13.50708@avtrex.com> <m3fy2vuwb9.fsf@fleche.redhat.com>

Tom Tromey wrote:

"David" == David Daney <ddaney@avtrex.com> writes:
David> Whilst hacking things up to get MIPS64 working better in libffi, I
David> came across several test cases where structure elements were declared
David> as type 'int' but the libffi type specifier identified them as uint32.
David> This patch corrects some (but probably not all) of these incongruities.

I think a patch to fix a disparity like this would qualify as obvious.
However... if the struct definition says 'int', and the test case is
says ffi_type_sint32, then that seems like a bug in itself.  There's
no guarantee that int == 32 bits.  Wouldn't it be more correct to use
ffi_type_sint?

I thought of that after I sent the patch, and I agree. The problem is pervasive in the testsuite. Patch withdrawn.

I will submit a revised patch soon.

David Daney

References:
- [Patch] libffi testsuite: Correct some type specifiers.
  - From: David Daney
- Re: [Patch] libffi testsuite: Correct some type specifiers.
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]