This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Add NormalBreakpoint


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Right, the other new breakpoint type, ExecuteMethodBreakpoint will
Keith> also set this. interpret-run.cc will then use Breakpoint.type() to
Keith> figure out how to handle the breakpoint. Call me old fashioned, but I
Keith> really dislike using instanceof. O:-)

Classic OO would be to put a method on the Breakpoint so the different
types know how to handle themselves :-)

Adding a type field just to avoid instanceof doesn't seem so great,
unless there's a particular reason.  But if you really want to do it,
it seems to me that the allowable values should be defined in the base
class.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]