This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
[RFA] Fix JDWP ThreadReference.Resume
- From: Kyle Galloway <kgallowa at redhat dot com>
- To: GCJ-patches <java-patches at gcc dot gnu dot org>
- Date: Wed, 28 Mar 2007 15:24:25 -0400
- Subject: [RFA] Fix JDWP ThreadReference.Resume
This trivial patch fixes an error that would result in the inability for
JDWP to resume threads. Currently, when JDWP goes to "resume" a thread,
it will call suspend on it again which will just increase the suspend
count, not cause the thread to resume. This went into Classpath
yesterday, and I think it's important enough we should fix it here.
ChangeLog
2007-03-28 Kyle Galloway <kgallowa@redhat.com>
* classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java
(executeResume): Call VMVirtualMachince.resumeThread.
Questions/comments/concerns?
- Kyle
Index: libjava/classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java
===================================================================
--- libjava/classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java (revision 123266)
+++ libjava/classpath/gnu/classpath/jdwp/processor/ThreadReferenceCommandSet.java (working copy)
@@ -142,7 +142,7 @@
{
ThreadId tid = (ThreadId) idMan.readObjectId(bb);
Thread thread = tid.getThread();
- VMVirtualMachine.suspendThread(thread);
+ VMVirtualMachine.resumeThread(thread);
}
private void executeStatus(ByteBuffer bb, DataOutputStream os)