This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] JVMTI GetArgumentsSize

Tom Tromey wrote:
"Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:

Kyle> + for (;sig[i] != ';'; i++);

As a general rule we prefer to see the ';' for an empty loop on its
own line.  This emphasizes that the loop is intentionally empty and
not merely a typing error of some kind.

However in this case it is better to write this as a while:

  while (sig[i] != ';')
    ++i;

Ok with that change.
Changed and committed.

Thanks,
Kyle

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]