Re: Patch: RFC: fix ProcessBuilder; windows help needed

[Mohan Embar <gnustuff at thisiscool dot com>]

Hi Tom,

>Mohan> To summarize, I'd like to know exactly what scripts to run
>Mohan> after I apply your patch (and ideally, why I'm running them).
>
>Download ecj.jar using the contrib/download_ecj method
>Configure with --enable-java-maintainer-mode.
>Apply patch.
>./scripts/makemake.tcl > sources.am
>automake
>Build.
>When the build fails, run classes.pl and insert output into javaprims.h
>Rebuild

I did the following (trying to do a native i686-pc-linux-gnu build):

- Checked out svn trunk to /datal/gcc
- Went to /datal/gcc/gcc and ran contrib/download_ecj
- Configured and built a Linux native gcc without
  --enable-java-maintainer-mode
- Moved the resultant compiler to /datal/gcc/nativegcc
- Put /datal/gcc/nativegcc/bin in my path and 
  /datal/gcc/nativegcc/lib in LD_LIBRARY_PATH
- Created the following script called ecj1 in /datal/gcc/nativegcc/bin:

======================
#! /bin/sh
gij -cp /datal/gcc/gcc/ecj.jar org.eclipse.jdt.internal.compiler.batch.GCCMain ${1+"$@"}
======================

- Blew away my build directory
- Went to /datal/gcc/gcc/libjava
- With automake 1.96 and autoconf 2.59 in my path, did:

======================
<Apply patch.>
./scripts/makemake.tcl > sources.am
automake
======================

- Configured gcc like this:

======================
$GCC_SRC_DIR/configure --prefix=$PREFIX \
    --enable-languages=c,c++,java \
    --with-mpfr=$GMP_MPFR_DIR \
    --with-gmp=$GMP_MPFR_DIR \
    --with-gcc --with-gnu-as --with-gnu-ld \
    --enable-threads=posix --disable-nls \
    --enable-shared --disable-debug \
    --enable-libgcj  --disable-java-awt --without-x \
    --disable-libgcj-debug --enable-interpreter --enable-hash-synchronization \
    --enable-java-maintainer-mode
======================

- Built.

The build fails, but no VMProcess.class (new class in patch) is built.

What's more, the --enable-java-maintainer-mode switch isn't present
in $builddir/i686-pc-linux-gnu/libjava/config.log. I also get these in config.log:

JAVA_MAINTAINER_MODE_FALSE=''
JAVA_MAINTAINER_MODE_TRUE='#'

Am I missing something? Do I need to do --enable-maintainer-mode on top of
--enable-java-maintainer-mode? Why isn't this flag being passed down?

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/