This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Tom Tromey wrote:I just noticed a small thinko in this patch that might cause some problems, so I am checking in a fix as trivial.Kyle> Comments, or can I commit this?Changed and committed.
Just one change.
Kyle> +# Run the JVMTI tests. Kyle> +proc gcj_jvmti_run {} { [...] Kyle> + Kyle> +gcj_jvmti_run
Name this gij_jvmti_run. It is ok to redefine procs in Tcl, but it is a bit clearer if they have unique names. (I see you did this elsewhere so I guess you just missed this one :)
This is ok with this change.
* testsuite/libjava.jvmti/lib/libjava.exp (exec_gij): Change [ to { in if statement.
Thanks, Kyle
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |