This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch: FYI: fix TransformerImpl buglet
- From: Tom Tromey <tromey at redhat dot com>
- To: GNU Classpath Patches <classpath-patches at gnu dot org>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 10 Oct 2006 13:20:15 -0600
- Subject: Patch: FYI: fix TransformerImpl buglet
- Reply-to: tromey at redhat dot com
I'm checking this in to Classpath, gcc svn head, and the RH 4.1
branch.
This fixes PR 29362, a TransformerImpl buglet pointed out by the
Eclipse CDT. I'm not completely sure that this is the best fix, but
we did test it against the CDT and it removed the particular failure
we were seeing.
FYI there's a self-contained test case in the PR.
Tom
2006-10-10 Tom Tromey <tromey@redhat.com>
PR classpath/29362:
* gnu/xml/transform/TransformerImpl.java (transform): Only strip if
there is a stylesheet.
Index: gnu/xml/transform/TransformerImpl.java
===================================================================
RCS file: /cvsroot/classpath/classpath/gnu/xml/transform/TransformerImpl.java,v
retrieving revision 1.15
diff -u -r1.15 TransformerImpl.java
--- gnu/xml/transform/TransformerImpl.java 7 Jun 2006 08:04:49 -0000 1.15
+++ gnu/xml/transform/TransformerImpl.java 10 Oct 2006 19:23:31 -0000
@@ -327,7 +327,8 @@
domDoc.setCheckWellformedness(false);
}
parent.normalize();
- strip(stylesheet, parent);
+ if (stylesheet != null)
+ strip(stylesheet, parent);
Document resultDoc = (parent instanceof Document) ?
(Document) parent :
parent.getOwnerDocument();