Re: [gcjx] RFC/RFA: Show Problematic Source Lines with Diagnostics

[Ranjit Mathew <rmathew at gmail dot com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tom Tromey wrote:
> 
> I think this patch is ok.  Please check it in.

Thanks. I checked it in. I've also updated TODO to
remove the lines I had added about this a couple
of days ago.


> One concern I have with this approach is that we'll end up using a lot
> more memory, by keeping all the file contents around.  At present this
> won't look so bad, since we only use mmap, but eventually we're going
> to have to handle the read case as well.  But, maybe the problem won't
> be so bad.  And anyway, if it is, we can change how this is
> implemented.  For instance, we could throw away the data and just keep
> the file descriptor around.

Yes, in which case we'll match the current GCJ front-end. :-)


> Ranjit> Note that the wrong line and column is shown here. But that's
> Ranjit> not my fault - the incoming information was wrong to begin
> Ranjit> with!
> 
> I have a fix for this.  The lexer wasn't properly handling unget() of
> a newline.

Cool. You have saved me much head-scratching trying to figure
this out.

Ranjit.

- --
Ranjit Mathew       Email: rmathew AT gmail DOT com

Bangalore, INDIA.     Web: http://ranjitmathew.hostingzero.com/




-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDQXVEYb1hx2wRS48RAoOfAJ0W+Rz5MXYHGTd3B5fj26nuNNGGaACgjgLM
PzOCXMrSt2Rj/D6TMQnHkkY=
=SgNU
-----END PGP SIGNATURE-----