Re: Patch: FYI: Get xlib peers working again - OK for branch-4.0?

[Thomas Fitzsimmons <fitzsim at redhat dot com>]

On Wed, 2005-07-20 at 16:14 -0600, Tom Tromey wrote:
> >>>>> "Scott" == Scott Gilbertson <scottg@mantatest.com> writes:
> 
> Scott> Tom > ClasspathToolkit now declares some
> Scott> Tom > abstract methods that the xlib peers do not implement.
> 
> Scott> I'm a little concerned about that.  The method in question is
> Scott> createEmbeddedWindow.  Since it is in my opinion a new,
> Scott> optional feature, I don't think it should be abstract in
> Scott> ClasspathToolkit.  Instead, the base implementation ought to
> Scott> return null or throw an UnsupportedOperationException, which
> Scott> means a specific toolkit (XToolkit, for example) wouldn't need
> Scott> modification unless and until it wanted to implement the
> Scott> optional feature.
> 
> That sounds reasonable to me.  Tom F., what do you think?

Yeah, that's fine by me.

Tom