This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA/JDWP] ThreadGroupReferenceCommandSet.java
- From: Tom Tromey <tromey at redhat dot com>
- To: Aaron Luchko <aluchko at redhat dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, classpath patches <classpath-patches at gnu dot org>
- Date: 20 Jul 2005 11:14:38 -0600
- Subject: Re: [RFA/JDWP] ThreadGroupReferenceCommandSet.java
- References: <1121794862.7462.11.camel@tomaluk.toronto.redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Aaron" == Aaron Luchko <aluchko@redhat.com> writes:
Aaron> 2005-07-12 Aaron Luchko <aluchko@redhat.com>
Aaron> * gnu/classpath/jdwp/processor/ThreadGroupReferenceCommandSet.java:
Aaron> Implemented the ThreadGroupReference CommandSet.
Aaron> + throw new NotImplementedException("Command " + command +
Aaron> + " not found in String Reference Command Set.");
I think "String" is wrong here.
Aaron> + private void executeParent(ByteBuffer bb, DataOutputStream os)
Aaron> + throws JdwpException, IOException
Aaron> + {
Aaron> + ObjectId oid = idMan.readId(bb);
Aaron> + ThreadGroup group = (ThreadGroup) oid.getObject();
Aaron> + ThreadGroup parent = group.getParent();
ThreadGroup.getParent() does a security access check.
What is the plan here? One idea would be to use
AccessController.doPrivileged to perform these actions.
Or, I suppose that could be done at a higher level in the code that
dispatches the commands.
Tom