This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA] JDWP packet classes
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: GCJ Patches <java-patches at gcc dot gnu dot org>, classpath patches <classpath-patches at gnu dot org>
- Date: 01 Jun 2005 12:45:08 -0600
- Subject: Re: [RFA] JDWP packet classes
- References: <1117642496.4518.11.camel@lindt.uglyboxes.com>
- Reply-to: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> So, since there seems to be some consensus about including this JDWP
Keith> stuff into classpath, I've refactored the code and updated the coding
Keith> style according to the classpath documentation. I may have missed
Keith> something, so if I did, please let me know.
You forgot to refactor the ChangeLog entry :-)
Otherwise, just one more buglet. With this fix it is ok, you don't
have to post it again.
+ id = ((bytes[i++] & 0xff) << 24 | (bytes[i++] & 0xff) << 16
+ | (bytes[i++] & 0xff) << 8 | bytes[i++]);
The final bytes[i++] needs an "& 0xff", as the byte value will be
promoted to int and sign extended here. I think there are a few cases
of this.
I think it is ok to check this in to libgcj and wait until you get a
Classpath account for that side.
Tom