Re: [Patch] JNI support for direct buffers

[Michael Koch <konqueror at gmx dot de>]

Am Freitag, 7. Januar 2005 12:15 schrieb Andrew Haley:
> Michael Koch writes:
>  > After a discussion on irc with Bryce McKinley I added two
>  > additional checks into the implementations of
>  > GetDirectBufferAddress and GetDirectBufferLength. New patch
>  > attached.
>  >
>  > Ok to commit ?
>  >
>  > 2005-01-07  Michael Koch  <konqueror@gmx.de>
>  >
>  >  * java/nio/Buffer.java
>  >  (address): New field.
>  >  * java/nio/DirectByteBufferImpl.java
>  >  (address): Removed.
>  >  * java/nio/MappedByteBufferImpl.java
>  >  (address): Likewise..
>  >  * java/nio/CharViewBufferImpl.java
>  >  (CharViewBufferImpl): Explicitely initialize Buffer.address if
>  > needed.
>
> explicitly
>
>  >  * java/nio/DoubleViewBufferImpl.java
>  >  (DoubleViewBufferImpl): Likewise.
>  >  * java/nio/FloatViewBufferImpl.java
>  >  (FloatViewBufferImpl): Likewise.
>  >  * java/nio/IntViewBufferImpl.java
>  >  (IntViewBufferImpl): Likewise.
>  >  * java/nio/LongViewBufferImpl.java
>  >  (LongViewBufferImpl): Likewise.
>  >  * java/nio/ShortViewBufferImpl.java
>  >  (ShortViewBufferImpl): Likewise.
>  >  * jni.cc (_Jv_JNI_GetDirectBufferAddress): Don't assume buffer
>  > is a DirectByteBufferImpl object.
>  >  (_Jv_JNI_GetDirectBufferCapacity): Likewise.
>  >  * testsuite/libjava.jni/directbuffer.c,
>  >  testsuite/libjava.jni/directbuffer.java,
>  >  testsuite/libjava.jni/directbuffer.out,
>  >  testsuite/libjava.jni/bytebuffer.c,
>  >  testsuite/libjava.jni/bytebuffer.java,
>  >  testsuite/libjava.jni/bytebuffer.out: New files.
>
> OK, but please add the PR when you check in the ChangeLog.

Thanks. Done and commited.

> BTW, something bad happened to your ChangeLog formatting.

No, it was intentional this way but I reformatted it before commit 
especially for you. ;-)


Michael
-- 
Homepage: http://www.worldforge.org/