This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: RFA: Fix PR libgcj/17623
- From: Tom Tromey <tromey at redhat dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 22 Sep 2004 16:53:20 -0600
- Subject: Re: Patch: RFA: Fix PR libgcj/17623
- References: <4151F93F.4060109@avtrex.com>
- Reply-to: tromey at redhat dot com
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> OK to commit if no regressions?
If there isn't already a Mauve test for this, could you add one?
The getUserInfo() part of the patch looks like it also needs a test
case of some kind; maybe some protocols don't set this field on the
URL? I don't really get this code.
David> + if(userInfo != null)
Space between "if" and "(".
Otherwise, this is OK, thanks.
Tom