This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: gnu.java.net.protocol.file.Handler
Michael Koch wrote:
On Friday 10 September 2004 17:39, Bryce McKinlay wrote:
Hmm, this looks ok, but I'm not sure that "keeping the current
protocol" is the right behaviour if ftp is unavailable. An
exception should be thrown at some point, IMO. What will happen
with this patch if someone tries to connect an ftp URL, but the ftp
handler is not installed?
To answer this this question fully: An exception will be thrown saying
"ftp: protocol not supported".
OK, so the only thing this patch changes is to remove a redundant check
from file.Handler.openConnection() ?
If so, the comment seems unclear to me. Wouldn't it be better to say
something like "If the ftp protocol handler is not installed, an
exception will be thrown from the new openConnection() call.". Also, we
should assume that ftp will be supported at some point and not explicity
say it isn't here.
Otherwise the patch is OK, thanks.
Bryce