This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch ping: MIPS ffi=o32 patch...
- From: David Daney <ddaney at avtrex dot com>
- To: Bryce McKinlay <mckinlay at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, java-patches at gcc dot gnu dot org, Casey Marshall <csm at gnu dot org>
- Date: Fri, 13 Aug 2004 17:22:31 -0700
- Subject: Re: Patch ping: MIPS ffi=o32 patch...
- References: <411BB221.9070108@avtrex.com> <411BCD84.8090301@redhat.com>
Bryce McKinlay wrote:
> David/Casey,
>
> I'm no MIPS or libffi expert, but this patch looks fine to me. You
> should also check that libffi's ffitest continues to work on MIPS.
> Otherwise, OK to commit.
>
The libffi testsuite contains all the tests that were in ffitest and more.
Here is my problem. I configured GCC --with-float=soft which has a
different ABI than --with-float=hard. Casey's implementation works only
with hard float.
The good news is we get many XPASSes. The failures I see are for
floating point and structure parameters and return values.
I would like to commit as is, and then as a follow up patch fix things
so that the soft float ABI works also.
I am assuming that hard float works on Casey's word.
May I do this?
David Daney