This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] support security.manager property
- From: Tom Tromey <tromey at redhat dot com>
- To: Casey Marshall <csm at gnu dot org>
- Cc: java-patches at gcc dot gnu dot org
- Date: 30 Jul 2004 09:53:28 -0600
- Subject: Re: [PATCH] support security.manager property
- References: <87vfg6w032.fsf@gnu.org>
- Reply-to: tromey at redhat dot com
>>>>> "Casey" == Casey Marshall <csm@gnu.org> writes:
Casey> 2004-07-29 Casey Marshall <csm@gnu.org>
Casey> * prims.cc (_Jv_RunMain): install a security manager if the
Casey> `security.manager' property is set.
This looks good to me.
Could you add an entry for this to the System Properties node of
gcc/gcc/java/gcj.texi?
I also have a couple formatting nits below.
Casey> + java::lang::String *smgr = java::lang::System::getProperty
Casey> + (JvNewStringLatin1 ("security.manager"));
Hmm, try breaking before the `=' instead to see if that helps.
Sometimes I add a "using" to make the indentation look nicer.
Casey> + java::lang::Runtime::securityManager =
Casey> + new java::lang::SecurityManager();
Line break before `=', not after.
Casey> + if (!java::lang::SecurityManager::class$.isAssignableFrom (clazz))
Space after "!".
Tom