Re: [patch] Implement java.beans.Expression

[Mark Wielaard <mark at klomp dot org>]

Hi,

On Fri, 2004-06-25 at 17:27, jlquinn@optonline.net wrote:
> > On Thu, 2004-06-24 at 07:10, Jerry Quinn wrote:
> > > This depends on http://gcc.gnu.org/ml/java-patches/2004-q2/msg00739.html
> > >
> > > 2004-06-24  Jerry Quinn  <jlquinn@optonline.net>
> > >
> > >  * java/beans/Expression.java: New.
> > >  * Makefile.am: Add Expression.java.
> > >  * Makefile.in: Regenerate.
> > 
> > Very nice. Thanks for working on these classes.
> > Are you still waiting for approval to check them in?
> 
> Thanks.  Both the Expression.java and Statement.java patches are waiting for
> approval.
>
> >     Class klazz = (target instanceof Class)
> >                   ? (Class) target : target.getClass();
> > 
> > What do you think?
> 
> I also discovered this while testing Expression and have an equivalent fix in
> my Statement.java, but hadn't posted it.  Yours is cleaner, though.

Cool. I think after review by Michael and with this or a similar fixlet
both should go in. I cannot approve them for libgcj, but I intend to
make sure they go into GNU Classpath before the 0.10 snapshot release.
Tom? Bryce?

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part