This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Java: Definite [Un]Assignment Issues

From: Ranjit Mathew <rmathew at gmail dot com>
To: java-patches at gcc dot gnu dot org
Date: Sat, 29 May 2004 10:43:57 +0530
Subject: Re: [Patch] Java: Definite [Un]Assignment Issues
References: <c8qerl$o55$1@sea.gmane.org> <40B16AFF.8020909@bothner.com> <c8s6n5$47r$1@sea.gmane.org> <40B678BD.2040908@bothner.com> <39399b9d04052810593e23176a@mail.gmail.com> <40B78A9C.7050107@bothner.com>

On Fri, 28 May 2004 11:53:16 -0700, Per Bothner <per@bothner.com> wrote:
[...]
> > Is the following OK for mainline then?
> 
> Yes, though I have one minor suggestion:
> 
>           || (! DECL_LOCAL_FINAL_IUD (decl) && ! UNASSIGNED_P (before, index))
>           || (DECL_LOCAL_FINAL_IUD (decl) && ASSIGNED_P (before, index))))
> 
> should be:
> 
>           || (DECL_LOCAL_FINAL_IUD (decl) ? ASSIGNED_P (before, index)
>                : ! UNASSIGNED_P (before, index))

Thanks.


> > If yes, can I update jacks.xfail appropriately?
> 
> Ok.

Thanks. I've updated it like so:

Index: ChangeLog
from  Ranjit Mathew  <rmathew@hotmail.com>

	* testsuite/libjava.jacks/jacks.xfail: Update for post tree-ssa merge
	results.

Index: testsuite/libjava.jacks/jacks.xfail
===================================================================
--- testsuite/libjava.jacks/jacks.xfail	2004-05-29 10:20:33.000000000 +0530
+++ testsuite/libjava.jacks/jacks.xfail	2004-05-29 10:25:04.000000000 +0530
@@ -188,17 +188,9 @@
 15.13-anon-1
 15.14-runtime-3
 15.14-runtime-4
-15.14.1-final-2
-15.14.1-final-3
-15.14.2-final-2
-15.14.2-final-3
 15.15-precedence-5
 15.15-runtime-3
 15.15-runtime-4
-15.15.1-final-2
-15.15.1-final-3
-15.15.2-final-2
-15.15.2-final-3
 15.16-semantic-5
 15.16-value-1
 15.16-value-2
@@ -263,7 +255,6 @@
 15.20-2-runtime-1
 15.21-assoc-7
 15.21-assoc-8
-15.21-equal-3
 15.21-type-17
 15.21-type-21
 15.21-type-22
@@ -389,45 +380,23 @@
 16-static-2
 16.1.2-definite-unassignment-fail-6
 16.1.3-definite-unassignment-fail-6
-16.1.5-definite-unassignment-pass-4
-16.1.5-definite-unassignment-pass-7
 16.1.5-not-assignable-7
 16.1.5-not-assignable-8
-16.1.7-compound-definite-assignment-fail-8
-16.1.7-compound-definite-assignment-fail-9
-16.1.7-compound-definite-unassignment-fail-1
 16.1.7-compound-definite-unassignment-fail-6
 16.1.7-compound-definite-unassignment-fail-7
-16.1.7-compound-definite-unassignment-pass-6
-16.1.7-compound-definite-unassignment-pass-7
-16.1.7-simple-definite-assignment-fail-8
-16.1.7-simple-definite-assignment-fail-9
-16.1.7-simple-definite-unassignment-fail-1
-16.1.8-definite-unassign-fail-1
-16.1.8-definite-unassign-fail-2
-16.1.8-definite-unassign-fail-3
-16.1.8-definite-unassign-fail-4
-16.2.10-definite-assign-fail-2
 16.2.10-definite-assign-pass-2
-16.2.10-definite-unassign-fail-6
-16.2.10-definite-unassign-fail-7
-16.2.10-definite-unassign-fail-8
-16.2.10-definite-unassign-fail-9
 16.2.10-definite-unassign-pass-1
 16.2.10-definite-unassign-pass-2
+16.2.10-definite-unassign-pass-3
 16.2.10-definite-unassign-pass-4
 16.2.10-definite-unassign-pass-5
 16.2.10-definite-unassign-pass-6
 16.2.10-definite-unassign-pass-7
 16.2.10-definite-unassign-pass-8
-16.2.10-definite-unassign-pass-9
-16.2.11-definite-assign-fail-3
 16.2.11-definite-assign-pass-2
-16.2.11-definite-unassign-fail-7
-16.2.11-definite-unassign-fail-8
-16.2.11-definite-unassign-fail-9
 16.2.11-definite-unassign-pass-1
 16.2.11-definite-unassign-pass-2
+16.2.11-definite-unassign-pass-3
 16.2.11-definite-unassign-pass-4
 16.2.11-definite-unassign-pass-5
 16.2.11-definite-unassign-pass-6
@@ -442,14 +411,11 @@
 16.2.3-local-class-11
 16.2.3-local-class-4
 16.2.3-local-class-5
-16.2.3-switch-1
 16.2.5-definite-unassign-pass-1
 16.2.5-definite-unassign-pass-2
 16.2.5-definite-unassign-pass-3
-16.2.7-final-4
-16.2.7-final-6
-16.2.8-final-1
-16.2.8-final-2
+16.2.8-final-3
+16.2.8-final-4
 16.2.8-unassigned-1
 16.2.8-unassigned-20
 16.2.8-unassigned-21
@@ -458,26 +424,20 @@
 16.2.8-unassigned-6
 16.2.8-unassigned-8
 16.2.8-unassigned-9
-16.2.9-definite-assign-fail-3
 16.2.9-definite-assign-pass-2
-16.2.9-definite-unassign-fail-5
-16.2.9-definite-unassign-fail-6
-16.2.9-definite-unassign-fail-7
 16.2.9-definite-unassign-pass-1
 16.2.9-definite-unassign-pass-2
+16.2.9-definite-unassign-pass-3
 16.2.9-definite-unassign-pass-4
 16.2.9-definite-unassign-pass-5
 16.2.9-definite-unassign-pass-6
 16.2.9-definite-unassign-pass-7
-16.2.9-definite-unassign-pass-8
 16.5-anonymous-3
 16.5-runtime-1
 16.5-runtime-2
 16.5-runtime-3
 16.5-runtime-4
 16.5-runtime-5
-16.8-constructor-6
-16.8-constructor-7
 16.8-constructor-8
 3.10.1-invalid-3
 3.10.1-invalid-4
@@ -806,7 +766,6 @@
 9.2-implicit-19
 9.2-implicit-2
 9.2-implicit-3
-9.2-implicit-4
 9.2-implicit-6
 9.2-implicit-7
 9.3.1-illegal-forward-1
@@ -825,7 +784,6 @@ non-jls-jsr41.2-clash-1
 non-jls-jsr41.3-runtime-2
 non-jls-jsr41.4-definite-unassignment-fail-22
 non-jls-jsr41.4-definite-unassignment-pass-10
-non-jls-jsr41.4-definite-unassignment-pass-2
 non-jls-jsr41.4-definite-unassignment-pass-9
 non-jls-jsr41.4-definite-unassignment-try-1
 non-jls-jsr41.4-definite-unassignment-try-2

References:
- [Patch] Java: Definite [Un]Assignment Issues
  - From: Ranjit Mathew
- Re: [Patch] Java: Definite [Un]Assignment Issues
  - From: Per Bothner
- Re: [Patch] Java: Definite [Un]Assignment Issues
  - From: Per Bothner
- Re: [Patch] Java: Definite [Un]Assignment Issues
  - From: Ranjit Mathew
- Re: [Patch] Java: Definite [Un]Assignment Issues
  - From: Per Bothner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]