This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] SimpleTimeZone take 2


Michael Koch writes:
 > Am Freitag, 7. Mai 2004 15:30 schrieb Jerry Quinn:
 > > Michael Koch writes:
 > >  > Does the mauve test breaky compilation of mauve ? If yes we can
 > >  > exclude this test in mauve-libgcj file. Its always good to have
 > >  > the tests in mauve.
 > >
 > > It compiles fine.  But the test has failures since the library isn't
 > > correct.  I'm asking because usually tests don't get checked into the
 > > gcc testsuite while gcc is still broken.
 > >
 > > Maybe someone :-) should write a page describing checkin rules for
 > > mauve, such as gcc-style changelog, make sure mauve compiles, tests
 > > that fail are ok, etc...
 > 
 > There are no real rules for Mauve. Mauve is organized in an anarchic 
 > way: Everybody may nearly do everything.

Uh, Michael, you're being unreasonable.  Everybody may *not* do nearly
everything: changes require consensus.  This is not the Wild West, and
we are not cowboys.

A simple rule of thumb is "don't do things wildly diffferent from the
way they're done already".  This covers change logs, etc.

Of course tests that fail are OK, as long as they are correct.  That's
the whole point of having a test suite, surely.

 > > Hmm, insisting that a test doesn't fail is hard since it matters
 > > which VM and library is being used.  As far as compilation goes,
 > > is it OK to say as long as gcj mainline can compile the test, it
 > > can go in?
 > 
 > It can go in. The VMs that have not yet merged the new code (a.k.a. it 
 > doenst compile) can exclude the tests in their KEYS files. Failing 
 > tests are good as they show a deficit in a particalur VM.

They are indeed.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]