This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: Limit Heap Usage of Interpreter While Running Jacks
- From: Ranjit Mathew <rmathew at gmail dot com>
- To: tromey at redhat dot com
- Cc: java-patches at gcc dot gnu dot org
- Date: Sun, 25 Apr 2004 09:50:19 +0530
- Subject: Re: Patch: Limit Heap Usage of Interpreter While Running Jacks
- References: <c68rsv$4u1$1@sea.gmane.org> <871xmenycn.fsf@fleche.redhat.com>
> Ranjit> I propose that we modify "testsuite/libjava.jacks/jacks.exp" to
> Ranjit> explicitly limit the interpreter heap to 64MB as done in the
> Ranjit> following patch.
>
> Ranjit> OK for mainline?
>
> Could you add a comment before that line explaining the rationale?
> With that it is ok, please check in.
Thank you. I have committed the following:
Index: ChangeLog
from Ranjit Mathew <rmathew@hotmail.com>
* testsuite/libjava.jacks/jacks.exp (gcj_jacks_write): Explicitly
limit the maximum heap size to avoid unnecessary thrashing.
Index: testsuite/libjava.jacks/jacks.exp
===================================================================
RCS file: /cvs/gcc/gcc/libjava/testsuite/libjava.jacks/jacks.exp,v
retrieving revision 1.5
diff -u -p -U2 -r1.5 jacks.exp
--- testsuite/libjava.jacks/jacks.exp 11 Nov 2003 20:04:22 -0000 1.5
+++ testsuite/libjava.jacks/jacks.exp 25 Apr 2004 04:17:39 -0000
@@ -29,5 +29,10 @@ proc gcj_jacks_write {filename} {
puts $fd "set JAVAC_FLAGS [list $rest]"
puts $fd "set JAVA [list [libjava_find_gij]]"
- puts $fd "set JAVA_FLAGS \"\""
+
+ # Without an explicit limit on the heap size, tests depending on
+ # an OutOfMemoryError (e.g. "15.9.4-runtime-creation-2") can result
+ # in a lot of unnecessary thrashing.
+ puts $fd "set JAVA_FLAGS \"-mx=64m\""
+
puts $fd "set JAVAC_ENCODING_FLAG --encoding="
puts $fd "set tcltest::testConstraints(encoding) 1"