This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH for java/nio buffers
Michael Koch wrote:
* java/nio/Buffer.java: Add default constructor.
Why is this needed ? Its not in the official API.
* java/nio/ByteBuffer.java: Likewise.
Why is this needed ? Its not in the official API.
The official API has an implicit default constructor.
Our implementation has other non-public constructors, so
we have to have an explicit default constructor.
An alternative is to replace all the non-standard constructors
by static "factory" methods and init' metyhods, but that's a
change I didn't feel like making.
* java/nio/ByteBuffer.java (allocate): Re-implement using wrap.
>
Can we remove the constructor used here in old code completely ?
I'll try that.
(allocateDirect): Rename to allocate - direct is implied by context.
>
We can safely just remove this
method. It should never be called anyway.
I'll try that.
--
--Per Bothner
per@bothner.com http://per.bothner.com/