Re: [PATCH]: Channels and IllegalBlockingModeException

[Michael Koch <konqueror at gmx dot de>]

On Thu, Jan 29, 2004 at 08:34:49PM -0600, Mohan Embar wrote:
> Hi Michael,
> 
> >> On the other hand, I now have inIOOperation in two places:
> >> ServerSocketChannelImpl and SocketChannelImpl. I think I
> >> can move this to PlainSocketImpl and avoid the duplication.
> >> What do you think? (Remember that SocketChannelImpl and
> >> ServerSocketChannelImpl <i>must</i> use PlainSocketImpl
> >> and are not allowed to have a custom implementation.)
> >
> >Sounds like the right way.
> 
> This is my official submission of this:
> 
> http://gcc.gnu.org/ml/java-patches/2004-q1/msg00367.html
> 
> ...with the refactoring I mentioned above to put the "in channels
> operation" indicator in PlainSocketImpl instead of in both
> SocketChannelImpl and ServerSocketChannelImpl.
> 
> This passes my tests.
> 
> I didn't put " (" in any new code I wrote, but I also didn't
> change it in old code which I simply indented which shows
> up as new code in the diff.
> 
> I did and tested this against the trunk and I'm okay with it.
> Can you look at this one more time?

Please commit.


Michael