This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: Patch: java nio file locking

Michael Koch wrote:

I wonder how do you wanna implement anything file channel related when
you remove FileChannelImpl.

In my code I have "FileDescriptor extends FileChannel". So all of the file channel stuff moves to FileDescriptor. Or vice versa. My point is there is no need for two objects and two classes.

I would prefer a single natFileChannelImpl.cc too but the windows people
namely Mohan Embar requested the split.

I wonder why. It means it makes it difficult to share code in the native methods. That in turn encourages extra methods that do some checking in Java before calling a native methods htat does the work.
--
--Per Bothner
per@bothner.com http://per.bothner.com/

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]