This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Fix to KEY events
- From: Tom Tromey <tromey at redhat dot com>
- To: Fernando Nasser <fnasser at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: 03 Dec 2003 12:54:02 -0700
- Subject: Re: [PATCH] Fix to KEY events
- References: <3FCE388E.5050101@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Fernando" == Fernando Nasser <fnasser@redhat.com> writes:
Fernando> Most credits should go to Tom Fitzsimmons, but here is a fix
Fernando> for an annoying problem that would make any keypress (even a
Fernando> SHIFT key one) cause a checkbox to toggle, buttons to appear
Fernando> to have been pressed etc.
Fernando> + /* XXX We don't know what the intention was here, but
Fernando> + this is definitively _not_ the right thing to do
Fernando> gtk_widget_activate (window->focus_widget);
Fernando> + */
Normally we just delete unused code. Is it likely this code will be
resurrected in the near future? If not, let's just remove it.
Anyway, this is ok.
Hmm, I was going to say that we usually write "FIXME" instead of
"XXX", but grep shows that both seem to be pretty common. Learn
something every day :-)
Tom