This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix to KEY events


>>>>> "Fernando" == Fernando Nasser <fnasser@redhat.com> writes:

Fernando> Most credits should go to Tom Fitzsimmons, but here is a fix
Fernando> for an annoying problem that would make any keypress (even a
Fernando> SHIFT key one) cause a checkbox to toggle, buttons to appear
Fernando> to have been pressed etc.

Fernando> + 	        /* XXX We don't know what the intention was here, but 
Fernando> + 		   this is definitively _not_ the right thing to do
Fernando>   		gtk_widget_activate (window->focus_widget);
Fernando> + 		 */
  
Normally we just delete unused code.  Is it likely this code will be
resurrected in the near future?  If not, let's just remove it.

Anyway, this is ok.

Hmm, I was going to say that we usually write "FIXME" instead of
"XXX", but grep shows that both seem to be pretty common.  Learn
something every day :-)

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]