This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: FYI: Patch: java.net: socket stuff
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Michael Koch <konqueror at gmx dot de>, Dalibor Topic <robilad at kaffe dot org>
- Cc: java-patches at gcc dot gnu dot org
- Date: Tue, 25 Nov 2003 09:04:26 -0600
- Subject: Re: FYI: Patch: java.net: socket stuff
- Reply-to: gnustuff at thisiscool dot com
Hi People,
>I like the patch, though I'm not a gcj developer. I have one small nit
>to pick, though. Instead of copying
>
> if (isClosed())
> throw new SocketException("socket is closed");
>
>so many times, you could have used a private method to do the checking
>and throwing.
>
> checkIfIsClosed();
This is somewhat related to this:
http://gcc.gnu.org/ml/java-patches/2003-q4/msg00425.html
I combined the check into another private variant of getImpl(),
which could simplify the code even more. I wasn't happy with
my choice of names, though.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/