This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: java.net.URLStreamHandler
- From: Jeff Sturm <jsturm at one-point dot com>
- To: Bryce McKinlay <bryce at mckinlay dot net dot nz>
- Cc: Michael Koch <konqueror at gmx dot de>, <java-patches at gcc dot gnu dot org>
- Date: Tue, 28 Oct 2003 15:48:07 -0500 (EST)
- Subject: Re: Patch: java.net.URLStreamHandler
On Wed, 29 Oct 2003, Bryce McKinlay wrote:
> On Oct 29, 2003, at 8:11 AM, Michael Koch wrote:
>
> > The attached patch fixes a mauve failure. JDK prints the port number
> > always
> > if it was present in the URL spec, even if its equal to the default
> > port.
> > This patch fixes this.
> >
> > Please review and comment.
>
> Looks fine to me - but you should also remove the comment above this
> code, which will now be incorrect.
The comment seems to only describe the host == null or host.equals("")
cases. But the comment doesn't make much sense to me... Michael's patch
doesn't affect whether this URL is equivalent to the original.
I guess I don't understand the comment at all.
Jeff