Re: Patch: _Jv_pipe instead of ::pipe

[Michael Koch <konqueror at gmx dot de>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Freitag, 17. Oktober 2003 07:11 schrieb Mohan Embar:
> Hi People,
>
> This patch fixes this issue:
>
> http://gcc.gnu.org/ml/java-patches/2003-q4/msg00136.html
>
> I commented on this here:
>
> http://gcc.gnu.org/ml/java-patches/2003-q4/msg00138.html
>
> The patch opts for the second solution:
> >- a quicker and dirtier solution would be to define _Jv_Pipe in
> > both win32.h and posix.h and provide implementations for these in
> > both win32.cc and posix.cc. I was so relieved to eradicate all of
> > these, though, so doing this would be a step backward.
>
> Upon reflection (the human kind), I concluded that _Jv_pipe isn't
> as bad as all that because we're not dealing with networking here.
> The Win32 _pipe implementation is similar, and unlike the Windows
> Sockets functions, sets errno just like on UNIX, etc. In my initial
> post, I was thinking that the pipe stuff was analagous to the
> networking stuff, but now I don't think it is. This doesn't
> necessarily rule out forking the code later for other reasons,
> though.
>
> I've tested the Linux native and MinGW cross builds, but only
> for successful compilation and linking since this code isn't
> finished yet.

Looks good, please go for it.


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/kAvoWSOgCCdjSDsRApI0AJkBr6EuLjiHKbhchkJGL3gSy+8MDQCfYhW5
1VR+oZeMH4N9/ag1skXnP1E=
=mfmx
-----END PGP SIGNATURE-----