This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Lightweight peer implementation

From: "Scott Gilbertson" <scottg at mantatest dot com>
To: "Thomas Fitzsimmons" <fitzsim at redhat dot com>
Cc: "Bryce McKinlay" <bryce at mckinlay dot net dot nz>,"GCJ Patch List" <java-patches at gcc dot gnu dot org>
Date: Wed, 13 Aug 2003 13:30:12 -0400
Subject: Re: Lightweight peer implementation
References: <0968DFD6-CC56-11D7-8F3E-003065F97F7C@mckinlay.net.nz> <00fb01c360e0$9b2156a0$3c16a8c0@mantatest.com> <1060794968.12238.1235.camel@tortoise.toronto.redhat.com>

From: "Thomas Fitzsimmons"
> OK, here is another patch that builds on Scott's.  I've left the
> Component null checks alone for now.  The patch moves GLightweightPeer
> to gnu.java.awt.peer and implements some of the missing ComponentPeer
> methods.
>
> Comments?

Looks about right to me, except that the patch includes a comment insertion
in java.awt.Component, which I don't think was necessary and is not
mentioned in the change log.  Also, I guess Makefile.in needs to be included
as "re-generated".  In the JRE, the parameter to Toolkit.createComponent is
called "target", but I don't know if it's important for us to match that.

Follow-Ups:
- Re: Lightweight peer implementation
  - From: Tom Tromey
- Re: Lightweight peer implementation
  - From: Thomas Fitzsimmons

References:
- Re: Lightweight peer implementation
  - From: Bryce McKinlay
- Re: Lightweight peer implementation
  - From: Scott Gilbertson
- Re: Lightweight peer implementation
  - From: Thomas Fitzsimmons

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]