Re: [PATCH] unit-at-a-time for java

[Jeff Sturm <jsturm at one-point dot com>]

On Tue, 22 Jul 2003, Jan Hubicka wrote:
> > Jan, I'm not sure what the comment regarding current_function_decl means.
> > However the java inliner requires this to be set to the outermost calling
> > function.  I don't know what the impact to C/C++ is.  (If that won't work
> > I suppose we could introduce a new variable.)
>
> Your change will work. the inliner just avoids inlining of
> current_function_decl so when the current_funcntion_decl is set to
> something that we want to inline we lose.  setting it to the function
> itself is OK as we don't do recursive inlining yet.

Thanks for reviewing.  Maybe we can do a little longer comment, something
like:

/* The tree inliner avoids current_function_decl, so set it to something
   that won't be inlined anyway.  We don't inline recursion yet, so this
   is safe.

   Plus, the java tree inliner currently needs this to be set to the
   outermost caller to merge class initialization checks.  */

Bootstrap has completed without regressions.  Are the java and cgraphunit
patches OK for mainline?  (Andrew will have to review the java
changes.)

Jeff