Re: Patch: MingW32 3.4 Cleanup / Refactoring / Enhancements

[Mohan Embar <gnustuff at thisiscool dot com>]

Hi Michael,

>I'm for this patch with one point against it: It doenst support the 
>configure option --disable-java-net (as Ranjit mentioned earlier). If 
>we drop this option for windows this should be visible in the output 
>of ./configure --help. I have not compiled libgcj with the patch but 
>I think it is okay when Ranjit says its okay. If Ranjit agrees and 
>has not more points agains it you can commit it.

Thanks for looking at this again.

For the --disable-java-net issue, see the last section of this post:

http://gcc.gnu.org/ml/java-patches/2003-q3/msg00015.html

You removed all of the #ifdef DISABLE_JAVA_NET..#endif sections in
your POSIX code for the exact same reasons that I now have done in
the Win32 code, because specifying --disable-java-net should link
to the nat*NoNet.cc files and bypass the Win32 files altogether.

So Ranjit, can you now give your final blessing (or curse)? Again,
the only difference between this patch and the previous one you saw
is:

- I split out your os.arch and process quoting patches
- I fixed a connect() bug in natPlainSocketImplWin32 which
  occurred for non-zero timeouts

-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/