This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Eliminate gc.h warning
- From: "Zack Weinberg" <zack at codesourcery dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: java-patches at gcc dot gnu dot org
- Date: Thu, 03 Jul 2003 13:05:36 -0700
- Subject: Re: Eliminate gc.h warning
- References: <20030702051354.GB27592@ftbfs.org><874r25fny8.fsf@egil.codesourcery.com><20030703195431.GF26935@ftbfs.org>
Matt Kraai <kraai@alumni.cmu.edu> writes:
> On Tue, Jul 01, 2003 at 11:21:51PM -0700, Zack Weinberg wrote:
>> Matt Kraai <kraai@alumni.cmu.edu> writes:
>>
>> > Howdy,
>> >
>> > boehm-gc/include/gc.h generates the following warning:
>> >
>> > In file included from ../../../../gcc/libjava/java/lang/natObject.cc:282:
>> > ../../../../gcc/boehm-gc/include/gc.h:53:1: warning: "GC_LINUX_THREADS" redefined
>> > <command line>:12:1: warning: this is the location of the previous definition
>> >
>> > The following patch eliminates this warning.
>>
>> Instead, (a) figure out whether it is actually necessary to define
>> this on the command line, and if not, take it off; (b) if it is,
>> #define GC_LINUX_THREADS 1 instead of wrapping it in #if !defined.
>
> The following patch omits the contents of boehm-cflags from the
> libjava compile line.
That's an awfully big hammer you got there. This may well be the
right thing to do but I want someone who *understands* Boehm GC to
comment.
zw