Re: libjava/java/io/natFileDescriptorPosix.cc -r1.25 -r1.26

[Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>]

In article <200305161011.53200.konqueror@gmx.de>,
Michael Koch<konqueror@gmx.de> writes:

>> I have this one for darwin, it may also be valid for *BSD?
>> Not reg tested yet.

> I commited the attached patch as a tempory fix until this is better 
> test.

> +/* FIXME: comment this out until its better tested/implemented
>    if ((jflags & SYNC))
>      flags |= O_SYNC;
 
>    if ((jflags & DSYNC))
>      flags |= O_DSYNC;
> +*/

Thank you for understanding the importance of maintaining general
bootstrap ability.  Humm, that is a tad more conservative than you
needed to be IMHO (i.e. systems that have O_SYNC may still use it
profitably until you/we fix it better).  I'd have been happy with this
construct:

/* FIXME: report inability to support SYNC, DSYNC with an exception? */
#ifdef O_SYNC
    if ((jflags & SYNC))
      flags |= O_SYNC;
#endif
#ifdef O_DSYNC
    if ((jflags & DSYNC))
      flags |= O_DSYNC;
#endif