This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: FYI: jni.cc fixes
- From: Tom Tromey <tromey at redhat dot com>
- To: Ulrich Weigand <weigand at immd1 dot informatik dot uni-erlangen dot de>
- Cc: java-patches at gcc dot gnu dot org
- Date: 04 Nov 2002 20:57:07 -0700
- Subject: Re: Patch: FYI: jni.cc fixes
- References: <200211042111.WAA01519@faui11.informatik.uni-erlangen.de>
- Reply-to: tromey at redhat dot com
>>>>> "Ulrich" == Ulrich Weigand <weigand@immd1.informatik.uni-erlangen.de> writes:
Ulrich> Though I'm not sure exactly why the sizeof (float) >=
Ulrich> sizeof (jfloat) is necessary; shouldn't this be rather
Ulrich> sizeof (double) >= sizeof (jfloat)? What you want to
Ulrich> check is that both jfloat and jdouble are equal to either
Ulrich> float or double (both of which are passed as double).
Yeah, thanks.
Ulrich> In any case, you didn't actually change the broken va_arg,
Ulrich> did you?
Oops.
It looks like:
else if (arg_elts[i] == JvPrimClass (long))
values[i].j = (jlong) va_arg (vargs, jlong);
Tom