This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] remerge most of java.rmi with Classpath


>>>>> "Nathanael" == Nathanael Nerode <neroden@doctormoo.dyndns.org> writes:

Nathanael> lose the 'super' call in their no-arg constructors.  This
Nathanael> doesn't make any practical difference, currently.
Nathanael> Theoretically, it might, if java.lang.Exception developed a
Nathanael> nontrivial constructor.

It doesn't make a difference in any situation, because the compiler
must emit the call to the superclass constructor.  Omitting the call
is probably a bit preferred stylistically.

Nathanael> There's some tiny content changes in RemoteException.java:
Nathanael> the special implementations of printStackTrace which
Nathanael> printed a trace for the cause, and then the regular trace,
Nathanael> have been removed in favor of the normal routines. This
Nathanael> appears to be part of the update for 1.4.

Nathanael> The only things which could break would be things which
Nathanael> depend on the format of stack traces, which isn't a safe
Nathanael> thing to do because I believe the format is not guaranteed
Nathanael> to remain stable, so I figured this wasn't a significant
Nathanael> change.

I agree.  I'm not concerned about this, and some of the exception
class merges I did yesterday have similar changes.

Nathanael> Someone with write access please commit. :-)

I'll do it shortly.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]