This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Infinitely long compilation
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- To: martin dot kahlert at infineon dot com
- Cc: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>, java at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Fri, 29 Mar 2002 14:07:11 -0800 (PST)
- Subject: Re: Infinitely long compilation
- References: <20020328074505.A20123@keksy.muc.infineon.com><3CA2C261.3080409@waitaki.otago.ac.nz><20020328085507.A20623@keksy.muc.infineon.com>
- Reply-to: apbianco at redhat dot com
Martin Kahlert writes:
> Perhaps the line *separator = c; could simply be left out,
Yes it should, as we're progressively changing the name.
I just re-organized your patch to what's below, gave it a try and I'm
now going to check it in.
Thanks,
2002-03-29 Martin Kahlert <martin.kahlert@infineon.com>
* parse.y (do_resolve_class): Fix infinite recursion
Index: parse.y
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/parse.y,v
retrieving revision 1.368
diff -u -p -r1.368 parse.y
--- parse.y 2002/03/29 21:58:49 1.368
+++ parse.y 2002/03/29 22:10:21
@@ -5868,18 +5868,20 @@ do_resolve_class (enclosing, class_type,
applicable and use the matching DECL instead. */
if (!decl_result && QUALIFIED_P (TYPE_NAME (class_type)))
{
- tree name = TYPE_NAME (class_type);
char *separator;
+ tree name = TYPE_NAME (class_type);
+ char *namebuffer = alloca (IDENTIFIER_LENGTH (name) + 1);
+
+ strcpy (namebuffer, IDENTIFIER_POINTER (name));
+
do {
/* Reach the last '.', and if applicable, replace it by a `$' and
see if this exists as a type. */
- if ((separator = strrchr (IDENTIFIER_POINTER (name), '.')))
+ if ((separator = strrchr (namebuffer, '.')))
{
- int c = *separator;
*separator = '$';
- name = get_identifier (IDENTIFIER_POINTER (name));
- *separator = c;
+ name = get_identifier (namebuffer);
decl_result = IDENTIFIER_CLASS_VALUE (name);
}
} while (!decl_result && separator);