This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: WIN-25.1: natPlainSocketImpl.cc [UPDATED]


>>>>> "Adam" == Adam Megacz <patches@lists.megacz.com> writes:

>> Ah, thanks. The problem is that implicit void* -> char* conversion is 
>> not allowed, however char* -> void*  should be perfectly fine.

Adam> So what's the final status on this? What do I need to do in order to
Adam> get my patch committed?

I think first Bryce should check in his recv patch.

About your patch:

* You need a newline before the definitions of write and read.
* Shouldn't write and read be static?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]