This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: WIN-25.1: natPlainSocketImpl.cc [UPDATED]

From: Tom Tromey <tromey at redhat dot com>
To: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
Cc: Adam Megacz <patches at lists dot megacz dot com>, java-patches at gcc dot gnu dot org
Date: 25 Feb 2002 17:06:40 -0700
Subject: Re: WIN-25.1: natPlainSocketImpl.cc [UPDATED]
References: <86lmdi1kx9.fsf@megacz.com> <86ofiel31l.fsf@megacz.com> <3C79AF13.8050107@waitaki.otago.ac.nz>
Reply-to: tromey at redhat dot com

>>>>> "Bryce" == Bryce McKinlay <bryce@waitaki.otago.ac.nz> writes:

Bryce> The _Jv_recv thing seems to break one platform or another every
Bryce> time someone changes it. Then again I always thought it was a
Bryce> bit of a hack, perhaps it would be better to just do some
Bryce> configure tests after all.

Yeah, I was hoping it would avoid error-prone configury hacking.
And it did, but it replaced it with error-prone _Jv_recv hacking.  Sigh.

I agree this shouldn't go in.  Also, defining close/read/write like
that looks suspicious.  Does Win32 never define these functions?

Tom

Follow-Ups:
- Re: WIN-25.1: natPlainSocketImpl.cc [UPDATED]
  - From: Adam Megacz

References:
- WIN-25: natPlainSocketImpl.cc
  - From: Adam Megacz
- WIN-25.1: natPlainSocketImpl.cc [UPDATED]
  - From: Adam Megacz
- Re: WIN-25.1: natPlainSocketImpl.cc [UPDATED]
  - From: Bryce McKinlay

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]